Set the flag *before* we retry the message

Go correctly caught this as a race condition.
IBM · Sep 24, 2015 · f15799e · f15799e
1 parent ce5f6fe
commit f15799e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/async_producer.go b/async_producer.go
@@ -667,8 +667,8 @@ func (f *flusher) groupAndFilter(batch []*ProducerMessage) map[string]map[int32]
 
 		if f.currentRetries[msg.Topic] != nil && f.currentRetries[msg.Topic][msg.Partition] != nil {
 			// we're currently retrying this partition so we need to filter out this message
-			f.parent.retryMessages([]*ProducerMessage{msg}, f.currentRetries[msg.Topic][msg.Partition])
 			msg.flags |= returned
+			f.parent.retryMessages([]*ProducerMessage{msg}, f.currentRetries[msg.Topic][msg.Partition])
 
 			if msg.flags&chaser == chaser {
 				// ...but now we can start processing future messages again