feat: support SaslHandshakeRequest v1 #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> If SaslHandshakeRequest version is v0, a series of SASL client and > server tokens corresponding to the mechanism are sent as opaque packets > without wrapping the messages with Kafka protocol headers. If > SaslHandshakeRequest version is v1, the SaslAuthenticate > request/response are used, where the actual SASL tokens are wrapped in > the Kafka protocol. The error code in the final message from the broker > will indicate if authentication succeeded or failed. References: https://kafka.apache.org/protocol#sasl_handshake https://kafka.apache.org/protocol#The_Messages_SaslHandshake https://kafka.apache.org/protocol#The_Messages_SaslAuthenticate Signed-off-by: Dominic Evans <[email protected]>
|
@bai can you take a look? |
|
Many thanks! (And thanks for poking me!) 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
https://kafka.apache.org/protocol#sasl_handshake
https://kafka.apache.org/protocol#The_Messages_SaslHandshake
https://kafka.apache.org/protocol#The_Messages_SaslAuthenticate