Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back Consumer.Offsets.CommitInterval default value #1616 #1618

Closed
wants to merge 1 commit into from
Closed

Add back Consumer.Offsets.CommitInterval default value #1616 #1618

wants to merge 1 commit into from

Conversation

reenjii
Copy link

@reenjii reenjii commented Feb 17, 2020

@reenjii reenjii requested a review from bai as a code owner February 17, 2020 16:04
@ghost ghost added the cla-needed label Feb 17, 2020
@reenjii
Copy link
Author

reenjii commented Feb 17, 2020

I signed Shopify's CLA, please re-launch the check. Thanks.

@ghost ghost removed the cla-needed label Feb 18, 2020
@bai bai requested a review from d1egoaz February 18, 2020 06:10
d1egoaz
d1egoaz reviewed Feb 18, 2020
View reviewed changes
config.go Show resolved Hide resolved
@d1egoaz
Copy link
Contributor

d1egoaz commented Feb 18, 2020

closed because of #1618 (comment)

Thanks anyways @reenjii

@d1egoaz d1egoaz closed this Feb 18, 2020
@d1egoaz d1egoaz mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d1egoaz d1egoaz d1egoaz left review comments

@bai bai Awaiting requested review from bai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reenjii @d1egoaz