Remove invalid broker by latest metadata

[Stephan14]

This pull request solves the problem: #1629. I find it only have update and add broker when update brokers by latest metadata, however there is no code of remove broker which if offline

[d1egoaz]

Hey @Stephan14
Could you please take a look at the tests? (are failing), and speaking of tests, could you please add some tests for your changes.

I think this will solve some problems that I'm seeing in some of my apps when we do rollout deployments on our kafka clusters.

Thanks!

[Stephan14]

hey @d1egoaz , I have fixed and add some tests and signed CLA, but it still show 7 falling checks. One of them shows pass on my mac as follow:

=== RUN   TestClientMetadataTimeout
--- PASS: TestClientMetadataTimeout (2.51s)
=== RUN   TestClientMetadataTimeout/timeout=250ms
    TestClientMetadataTimeout/timeout=250ms: client_test.go:702: Got err: kafka: client has run out of available brokers to talk to (Is your cluster reachable?) after waiting for: 313.008957ms
    --- PASS: TestClientMetadataTimeout/timeout=250ms (0.32s)
=== RUN   TestClientMetadataTimeout/timeout=500ms
    TestClientMetadataTimeout/timeout=500ms: client_test.go:702: Got err: kafka: client has run out of available brokers to talk to (Is your cluster reachable?) after waiting for: 508.929773ms
    --- PASS: TestClientMetadataTimeout/timeout=500ms (0.52s)
=== RUN   TestClientMetadataTimeout/timeout=750ms
    TestClientMetadataTimeout/timeout=750ms: client_test.go:702: Got err: kafka: client has run out of available brokers to talk to (Is your cluster reachable?) after waiting for: 833.03324ms
    --- PASS: TestClientMetadataTimeout/timeout=750ms (0.84s)
=== RUN   TestClientMetadataTimeout/timeout=900ms
    TestClientMetadataTimeout/timeout=900ms: client_test.go:702: Got err: kafka: client has run out of available brokers to talk to (Is your cluster reachable?) after waiting for: 826.578945ms
    --- PASS: TestClientMetadataTimeout/timeout=900ms (0.83s)
PASS

Process finished with exit code 0

But it shows as follow in github:

I can not understand why it show 7 falling checks

[Stephan14]

I find some new errors:

How to fix it?

[d1egoaz]

@Stephan14 not sure, I've been trying to re-run the tests and it's failing on the checkout action, nothing related to this change, it seems related to github actions, maybe @bai might know something about it

[Stephan14]

Hey @bai , how to fix the problem for me? Thank you

[d1egoaz]

@Stephan14 without closing this PR, can you try creating a new PR to see if that makes Github happy?

[Stephan14]

Hey @d1egoaz I have created a new PR, #1645

[dnwe]

I think we can continue discussion in #1645