Set tls ServerName to fix issue: either ServerName or InsecureSkipVerify must be specified in the tls.Config #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
requested changes
May 7, 2020
dnwe
approved these changes
May 7, 2020
d1egoaz
changed the title
|
Thanks for being around @dnwe |
bai
added a commit
to linkedin/Burrow
that referenced
this pull request
May 11, 2020
bai
added a commit
to linkedin/Burrow
that referenced
this pull request
May 11, 2020
Update sarama with a fix for IBM/sarama#1692
swade1987
added a commit
to eeveebank/burrow
that referenced
this pull request
May 15, 2020
* Add SASL-SCRAM ability to Kafka connection This PR adds the ability to connect to Kafka via SASL-SCRAM 256 or 512 It adds an entry in the SASL Profile configuration called key=mechanism value type=string required=no default value=(empty) Which accepts either values SCRAM-SHA-256, SCRAM-SHA-512 Partially addresses linkedin#526 * Ignore ZooKeeper znode Create if the path already exists Currently, Burrow will attempt to create the znode used by Burrow on startup This will cause problems if there is authentication needed when connecting to zk. The fix is to ignore creating zk node paths if it already exists * Yext specific Dockerfile the config file and dir used by Burrow is updated for M4 and Khan * Update module and import references go build -o build/Burrow github.com/rjh-yext/Burrow pulls in linkedin's branch of Burrow Changing references of linkedin to current fork * Fix Travis CI build. * Add Prometheus Metrics Exporter * Add support for Kafka 2.5.0 anf Go 1.14 * NameToCertificate only allows associating a single certificate with a given name. Leave that field nil to let the library select the first compatible chain from Certificates. * Update sarama with a fix for IBM/sarama#1692 * Removing CI jobs from upstream merge. Co-authored-by: Roger Hwang <[email protected]> Co-authored-by: rjh-yext <[email protected]> Co-authored-by: klDen <[email protected]> Co-authored-by: Michael Wain <[email protected]> Co-authored-by: Vlad Gorodetsky <[email protected]> Co-authored-by: Vlad Gorodetsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1691
TBH I'm not sure if this is enough.
There was a big change here:
https://github.com/Shopify/sarama/pull/1666/files#diff-019034382244c82f15c92490660e4a18
s/tls.DialWithDialer/tls.Clientand all code that was in
tls.DialWithDialeris not intls.Client, so no handshake, timeouts, etc.https://github.com/golang/go/blob/go1.14.2/src/crypto/tls/tls.go#L102