Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed variable names that are named same as some std lib package names #1738

Merged
merged 3 commits into from
Jul 15, 2020
Merged

fixed variable names that are named same as some std lib package names #1738

merged 3 commits into from
Jul 15, 2020

Conversation

varun06
Copy link
Contributor

@varun06 varun06 commented Jun 28, 2020

This is part of cleaning up some of the Lint and Vet issues. This is first PR in list of many PR's.

@varun06 varun06 requested a review from bai as a code owner June 28, 2020 14:47
@varun06 varun06 requested a review from d1egoaz June 28, 2020 14:47
d1egoaz
d1egoaz reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@d1egoaz d1egoaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of comments.
otherwise this looks great to me, I look forward for all the lint fixes! thanks for doing this! ❤️

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
async_producer_test.go Outdated Show resolved Hide resolved
async_producer_test.go Outdated Show resolved Hide resolved
async_producer_test.go Outdated Show resolved Hide resolved
consumer.go Show resolved Hide resolved
d1egoaz
d1egoaz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@d1egoaz d1egoaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@varun06 varun06 requested a review from dnwe July 5, 2020 18:36
@d1egoaz d1egoaz merged commit 4bc9b8f into IBM:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d1egoaz d1egoaz d1egoaz approved these changes

@bai bai Awaiting requested review from bai

@dnwe dnwe Awaiting requested review from dnwe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varun06 @d1egoaz