prod: explicitly log every state change #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I worked out the formal state machines of the relevant goroutines and stuck a log message in at every state change. This should help with debugging #179. The logs should still only trigger on broker rebalance or super-heavy traffic, so normal operation should be quiet.
| @@ -696,7 +700,6 @@ func (p *Producer) returnSuccesses(batch []*MessageToSend) { | |||
| } | |||
|
|
|||
| func (p *Producer) retryMessages(batch []*MessageToSend, err error) { | |||
| Logger.Println("Producer requeueing batch of", len(batch), "messages due to error:", err) | |||
There was a problem hiding this comment.
this was misleading because if the message had already been retried we would just flush it out the errors channel instead of requeueing it
|
|
this stuff is invaluable when debugging.
eapache
added a commit
that referenced
this pull request
Nov 15, 2014
prod: explicitly log every state change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked out the formal state machines of the relevant goroutines and stuck a
log message in at every state change. This should help with debugging #179.
The logs should still only trigger on broker rebalance or super-heavy traffic,
so normal operation should be quiet.
@wvanbergen