Update Kerberos library to latest major #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
force-pushed
the
update-gorkb-to-8
branch
from
72000ea to
05239a6
Compare
|
Thanks for contributing! LGTM, but I'll wait for another review for safety. |
bai
approved these changes
Jan 13, 2021
d1egoaz
reviewed
Jan 13, 2021
go.mod
Outdated
| github.com/golang/snappy v0.0.1 // indirect | ||
| github.com/google/go-cmp v0.4.0 // indirect | ||
| github.com/jcmturner/gokrb5/v8 v8.4.2 | ||
| github.com/klauspost/compress v1.9.8 |
There was a problem hiding this comment.
🤔 why this version was downgraded from v1.11.4?
d1egoaz
reviewed
Jan 13, 2021
go.mod
Outdated
| github.com/pierrec/lz4 v2.6.0+incompatible | ||
| github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 | ||
| github.com/frankban/quicktest v1.7.2 // indirect | ||
| github.com/golang/snappy v0.0.1 // indirect |
|
@kvch do you think you could rebase your branch and fix the downgrade issues in go.mod/go.sum? We're about to cut a new release soon. |
New import path: github.com/jcmturner/gokrb5/v8
bai
force-pushed
the
update-gorkb-to-8
branch
from
3c4841d to
13fa025
Compare
d1egoaz
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Kerberos library to the latest, v8.4.2. The version used in Sarama ATM is no longer supported. All fixes and features are added to the latest major.
New import path of the lib:
github.com/jcmturner/gokrb5/v8