Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct initial CodeQL findings #1926

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix: correct initial CodeQL findings #1926

merged 1 commit into from
Apr 28, 2021

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Apr 28, 2021

  • Incorrect conversion between integer types
  • Size computation for allocation may overflow

@dnwe dnwe requested a review from bai as a code owner April 28, 2021 09:53
bai
bai approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@bai bai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're fast, thank you! :shipit:

@dnwe
fix: correct initial CodeQL findings
d2ff778 
- Incorrect conversion between integer types
- Size computation for allocation may overflow
@dnwe dnwe merged commit 02d5c83 into master Apr 28, 2021
@dnwe dnwe deleted the dnwe/codeql branch April 28, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bai bai bai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnwe @bai