Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): enable and fix more linting rules #1931

Merged
merged 1 commit into from
May 5, 2021
Merged

feat(lint): enable and fix more linting rules #1931

merged 1 commit into from
May 5, 2021

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Apr 30, 2021

  • notably enable staticcheck as it is typically the best linter in terms of
    finding genuine issues.
  • add min TLS version of 1.2 (anything older is discontinued)
  • fix unused variables

@dnwe
feat(lint): enable and fix more linting rules
7333678 
- notably enable staticcheck as it is typically the best linter in terms of
  finding genuine issues.
- add min TLS version of 1.2 (anything older is discontinued)
- fix unused variables
@dnwe dnwe requested a review from bai as a code owner April 30, 2021 11:52
Base automatically changed from dnwe/fix-balance-strategy-test to master May 5, 2021 10:44
@dnwe dnwe merged commit ae85104 into master May 5, 2021
@dnwe dnwe deleted the dnwe/golangci-lint branch May 5, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bai bai Awaiting requested review from bai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dnwe