fix kafka-producer-performance throughput panic #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KerryJava
changed the title
dnwe
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Thanks — the fix looks good to me. It's not obvious what the original code intended — it seemed to attempt to duplicate the message (from the original generated set) throughput times before sleeping which is unusual. I think the new version which just keeps adding unique messages from the set and pausing whenever throughput in total have been put is more reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1969 fix kafka-producer-performance tool panic