fix(test): remove testLogger from TrackLeader test #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turns out, this setup was periodically causing the test to fail due to a data race occurring on the `Logger` global when the defer ran (!) Fixes #2011
dnwe
force-pushed
the
dnwe/no-test-logger
branch
from
8426dd8 to
fdf47c6
Compare
bai
approved these changes
Sep 14, 2021
|
Thanks! 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, this setup was periodically causing the test to fail
due to a data race occurring on the
Loggerglobal when the defer ran(!)
Fixes #2011