feat: send ApiVersionsRequest on broker open #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't use the actual response for anything, but lay the groundwork by sending an ApiVersionsRequest on broker open when the kafka version config has been set to 2.4.0.0 or newer. This is useful because the clientSoftwareName and version will show up in the server-side metrics. ``` kafka.server:clientSoftwareName=sarama,clientSoftwareVersion=1.30.0,listener=PLAINTEXT,networkProcessor=1,type=socket-server-metrics ```
bai
approved these changes
Sep 15, 2021
ijuma
reviewed
Oct 7, 2021
| // Send an ApiVersionsRequest to identify the client (KIP-511). | ||
| // Ideally Sarama would use the response to control protocol versions, | ||
| // but for now just fire-and-forget just to send | ||
| if conf.Version.IsAtLeast(V2_4_0_0) && conf.ApiVersionsRequest { |
There was a problem hiding this comment.
Why do we only send this if the version is at least 2.4.0? For older broker versions, the broker will send the response with an error that will be ignored and hence won't cause any harm. We just need to adjust the logging to avoid unnecessary noise depending on the version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't use the actual response for anything, but lay the
groundwork by sending an ApiVersionsRequest on broker open when the
kafka version config has been set to 2.4.0.0 or newer. This is useful
because the clientSoftwareName and version will show up in the
server-side metrics.