fix: return underlying sasl error message #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@k-wall thoughts? aside: I wonder if we need to tweak/condense the output as it comes from Sarama on the sentinel / multi error case: |
dnwe
force-pushed
the
dnwe/return-sasl-failure-message
branch
from
f7a62e9 to
4862c46
Compare
|
Added a commit to condense the default output a little which now gives: |
The SASL Authentication response message from Kafka has an additional field which can contain a description of why the authentication failed. Currently we drop this in Sarama and just return a generic message based on the kError code.
Add a customised default implementation of the multierror format func that is less verbose for single error multierrors (return them without the unnecessary "1 error occured:" prefix) and also condenses the output by removing one of the newline separators from between multiple errors in the output.
dnwe
force-pushed
the
dnwe/return-sasl-failure-message
branch
from
4862c46 to
f436782
Compare
This was referenced May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SASL Authentication response message from Kafka has an additional field which can contain a description of why the authentication failed. Currently we drop this in Sarama and just return a generic message based on the kError code.