Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix a potential data race on a global variable #2218

Closed
wants to merge 1 commit into from

Conversation

pior
Copy link
Contributor

@pior pior commented Apr 15, 2022

Re-apply the same fix as #2171 on v1.30.1

@dnwe
Copy link
Collaborator

dnwe commented Apr 21, 2022

@pior I'm not sure I understand? you've branched from the v1.30.1 tag and added the version.go fix that was previously merged to main — I guess this branch is for your own usage?

I'm not sure what the pull request is intended for though — were you hoping that we would make a 1.30.2 based on your branch?

@pior
Copy link
Contributor Author

pior commented Apr 21, 2022

I'm not sure what the pull request is intended for though — were you hoping that we would make a 1.30.2 based on your branch?

Maybe?
Since 1.30.1 is the last stable version (at least for us?), and it has this datarace bug, I think that would make sense until 1.33 is released.

@pior pior marked this pull request as ready for review April 21, 2022 15:12
@pior pior requested a review from dnwe April 21, 2022 15:12
@dnwe
Copy link
Collaborator

dnwe commented May 11, 2022

@pior apologies I didn't get back to you on this — I have now pushed out a release for 1.33, if you could give that a test and see if it resolves the issues you were seeing post-v1.30.1 that would be great

@dnwe dnwe closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants