Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): bump golangci version, cleanup, depguard config #2504

Merged
merged 2 commits into from
Jul 17, 2023
Merged

chore(ci): bump golangci version, cleanup, depguard config #2504

merged 2 commits into from
Jul 17, 2023

Conversation

EladLeev
Copy link
Contributor

Hi 👋
Good luck with the project ownership!
In this PR:

  • Bumped the golangci version to v1.53.3
  • Changed the local-prefixes to IBM
  • Commented out deprecated linters (replaced by unused )
  • Added some basic depguard configs - don't allow io/ioutil

@dnwe dnwe added the ci label Jul 17, 2023
@dnwe dnwe force-pushed the golangci-cleanup branch from e1bdfe5 to da48ff2 Compare July 17, 2023 21:46
dnwe
dnwe approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks good to me 👍

@dnwe dnwe merged commit fb81408 into IBM:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwe dnwe dnwe approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EladLeev @dnwe