Add some retry logic to more admin client functions #2520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the discussion here, you can use the retryOnError function when you are returning results by using a closure to capture the results. This PR wraps a few more functions with retry logic.
I stopped before doing any more in part because I was distracted by the inconsistent use of 'Acls', 'ACLs', etc in variables and function names. :-) (Something else for v2 perhaps).
I also wondered about the fact that the retryOnError function currently only checks for isNotControllerError and many of the functions that it wraps also check the error since they need to refresh the controller. Perhaps it would be better to make simpler retryOnError function like:
so that the functions can check the error once and return
true, err
. (Orfalse, err
for all other cases.)Or perhaps there is a better way? Suggestions welcome.