Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): resolve IDENTICAL_BRANCHES issue in broker #2992

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

frzifus
Copy link
Contributor

@frzifus frzifus commented Sep 30, 2024

The same code is executed when the condition "err != nil" is true or false, because the code in the if-then branch and after the if statement is identical.

The same code is executed when the condition "err != nil" is true or false, because the code in the if-then branch and after the if statement is identical.

Signed-off-by: Benedikt Bongartz <[email protected]>
@frzifus frzifus force-pushed the resolve_linting_issue branch from 9a05add to 47400a7 Compare September 30, 2024 09:47
Copy link
Contributor

@puellanivis puellanivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 no notes.

@frzifus
Copy link
Contributor Author

frzifus commented Oct 1, 2024

10/10 no notes.

mh?

@frzifus frzifus requested a review from puellanivis October 1, 2024 11:03
@puellanivis
Copy link
Contributor

mh?

I cannot Approve PRs here, but the PR is solid, and clean.

@dnwe dnwe merged commit 8d4b79b into IBM:main Oct 1, 2024
14 checks passed
@dnwe dnwe added the chore label Oct 1, 2024
@frzifus frzifus deleted the resolve_linting_issue branch October 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants