Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't import testing in the main lib #627

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Don't import testing in the main lib #627

merged 1 commit into from
Mar 10, 2016

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Mar 10, 2016

This was a minor regression from #570. Fixes #626.

@lvdlvd @wvanbergen

@lvdlvd
Copy link

lvdlvd commented Mar 10, 2016

Very nice. very fast response. thanks a bundle.

2016-03-10 22:40 GMT+01:00 Evan Huus [email protected]:

This was a minor regression from #570
#570. Fixes #626
#626.

@lvdlvd https://github.com/lvdlvd @wvanbergen

https://github.com/wvanbergen

You can view, comment on, or merge this pull request online at:

#627
Commit Summary

  • Don't import testing in the main lib

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#627.

eapache added a commit that referenced this pull request Mar 10, 2016
@eapache
Merge pull request #627 from Shopify/remove-testing-package
8717226 
Don't import `testing` in the main lib
@eapache eapache merged commit 8717226 into master Mar 10, 2016
@eapache eapache deleted the remove-testing-package branch March 10, 2016 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eapache @lvdlvd