Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo Flowsheet Test Failures #1198

Closed
eslickj opened this issue Jun 8, 2023 · 8 comments · Fixed by #1266
Closed

Demo Flowsheet Test Failures #1198

eslickj opened this issue Jun 8, 2023 · 8 comments · Fixed by #1266
Assignees
Labels
Priority:High High Priority Issue or PR

Comments

@eslickj
Copy link
Member

eslickj commented Jun 8, 2023

There are some demo flowsheet test failures on RHEL7 see https://github.com/IDAES/idaes-ext/actions/runs/5212024395/jobs/9405076893.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jun 8, 2023
@ksbeattie ksbeattie assigned bpaul4 and MarcusHolly and unassigned eslickj Sep 7, 2023
@ksbeattie
Copy link
Member

@bpaul4 & @MarcusHolly could you take a look to see if this is still an issue?

@andrewlee94
Copy link
Member

I am seeing some failures locally when I run these tests (these started failing in the past few days, and I am not sure why).

@MarcusHolly
Copy link
Contributor

@andrewlee94 To run these tests locally, do we run sh build.sh {platform} for the two failing jobs (centos7 and debian9)? If so, I'm seeing vulnerabilities but nothing specifically pointing to the demo flowsheet.

@andrewlee94
Copy link
Member

@MarcusHolly This shouldn't need you to build anything unless you are attempting to run the tests locally on different platforms (in which case I have no idea how to do it properly).

The better place to start would be to apply the DiagnosticsToolbox to the model and see what it comes up with first. If the problem is numeric, then it shouldn't matter what system you run it on - the issues will be the same across all systems but different systems might react differently to those issues.

@MarcusHolly
Copy link
Contributor

@andrewlee94 My tests are passing locally when I run them (Python 3.10.12; pytest-7.4.0; pluggy-1.2.0). However, when I copy these files over to a different environment (Python 3.8.13; pytest-7.1.3; pluggy-1.0.0), I'm getting an InitializationError. Is this what you're seeing locally as well? If so, I can work on resolving this.

According to the DiagnosticsToolbox, the only issue is two of the mole fracs being set at its upper bound (1). After resolving this, I still get no failures in my first environment and the same failures in my second environment...

@andrewlee94
Copy link
Member

I get two tests fail - the initialization test and the subsequent solve_flowsheet test. The error I see is:

E           idaes.core.util.exceptions.InitializationError: fs.M01.inlet_2_state failed to initialize successfully. Please check the output logs for more information.

idaes/models/properties/activity_coeff_models/activity_coeff_prop_pack.py:666: InitializationError

For the diagnostics, how many numerical cautions do you get (there might not be any warnings, but a lot of cautions is also a bad sign)? Also, make sure you run the tools on the failed initialization to see what it tells you then.

@MarcusHolly
Copy link
Contributor

MarcusHolly commented Sep 8, 2023

Okay, I'm seeing those same errors. And there are a lot of cautions (but no warnings), so I'll try to work through resolving this today.
image

@bpaul4
Copy link
Contributor

bpaul4 commented Oct 17, 2023

Completed via #1266.

@bpaul4 bpaul4 closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants