Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing Demo Flowsheet (Scaling) Failures #1266

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

MarcusHolly
Copy link
Contributor

Fixes

#1198

Summary/Motivation:

This flowsheet has run into scaling issues before, and they seem to have popped back up again...

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@MarcusHolly MarcusHolly added the Priority:Normal Normal Priority Issue or PR label Sep 8, 2023
@MarcusHolly MarcusHolly added the WIP label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (aa5212a) 76.66% compared to head (405c5ac) 76.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
+ Coverage   76.66%   76.87%   +0.20%     
==========================================
  Files         382      382              
  Lines       61615    61624       +9     
  Branches    11382    11382              
==========================================
+ Hits        47240    47375     +135     
+ Misses      11905    11780     -125     
+ Partials     2470     2469       -1     
Files Coverage Δ
idaes/models/flowsheets/demo_flowsheet.py 94.35% <100.00%> (+69.62%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcusHolly
Copy link
Contributor Author

@andrewlee94 Can you double check that all the tests are passing on your end too?

@MarcusHolly MarcusHolly marked this pull request as ready for review September 13, 2023 11:56
@andrewlee94 andrewlee94 added the CI:run-integration triggers_workflow: Integration label Sep 14, 2023
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Sep 14, 2023
Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still failing locally for me, but that could just be my local environment (which is due for a refresh).

@ksbeattie ksbeattie removed their request for review October 5, 2023 18:31
Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the flowsheet and tests run successfully in my local environment, using the latest main branch and latest release.

@andrewlee94 andrewlee94 merged commit 494b086 into IDAES:main Oct 16, 2023
40 checks passed
@bpaul4 bpaul4 linked an issue Oct 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo Flowsheet Test Failures
4 participants