-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing Demo Flowsheet (Scaling) Failures #1266
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
+ Coverage 76.66% 76.87% +0.20%
==========================================
Files 382 382
Lines 61615 61624 +9
Branches 11382 11382
==========================================
+ Hits 47240 47375 +135
+ Misses 11905 11780 -125
+ Partials 2470 2469 -1
☔ View full report in Codecov by Sentry. |
@andrewlee94 Can you double check that all the tests are passing on your end too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still failing locally for me, but that could just be my local environment (which is due for a refresh).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the flowsheet and tests run successfully in my local environment, using the latest main branch and latest release.
Fixes
#1198
Summary/Motivation:
This flowsheet has run into scaling issues before, and they seem to have popped back up again...
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: