-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated all mentions/use of anaconda/miniconda to reflect usage of mi… #1513
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
- Coverage 77.05% 77.04% -0.01%
==========================================
Files 384 384
Lines 62338 62338
Branches 10222 10222
==========================================
- Hits 48034 48031 -3
- Misses 11875 11879 +4
+ Partials 2429 2428 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Do we want apple silicon to be the default cpu to be checking in the Sphinx doc build check? Or intel? This can be found on line 37 in docs/tutorials/getting_started/mac_osx.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor things, but other than that this should be ready to merge.
corrected hyperlink in miniforge reference for sphinx docs
corrected hyperlink in miniforge reference for sphinx docs
I'm pretty sure the links that @ksbeattie pointed out are working now. I'm merging this in because I need these changes for fixing #1540. |
Fixes:
This resolves this issue: #1432
Summary/Motivation:
Idaes is no longer using miniconda and the codebase/documentation does not reflect the switch to Miniforge -- this PR updates everything to reflect the switch to Miniforge and removes references to Anaconda/Miniconda. Tried as best as possible to keep the wording closely aligned to what was represented before.
Changes proposed in this PR:
** There remains mentions of anaconda/miniconda in the docker/jenkinsfiles which I will remove in another PR -- the issue can be seen here: #1511
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: