Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated all mentions/use of anaconda/miniconda to reflect usage of mi… #1513

Merged
merged 11 commits into from
Nov 22, 2024

Conversation

azaidi06
Copy link
Contributor

Fixes:

This resolves this issue: #1432

Summary/Motivation:

Idaes is no longer using miniconda and the codebase/documentation does not reflect the switch to Miniforge -- this PR updates everything to reflect the switch to Miniforge and removes references to Anaconda/Miniconda. Tried as best as possible to keep the wording closely aligned to what was represented before.

Changes proposed in this PR:

  • Updated all mentions of Anaconda/Miniconda to now reflect what is needed to use miniforge instead.
  • Miniforge has separate builds for PowerPC and Arm architectures, this was not reflected in the original documentation so I just mentioned that explicitly and pointed to the link where the respective items can be found.

** There remains mentions of anaconda/miniconda in the docker/jenkinsfiles which I will remove in another PR -- the issue can be seen here: #1511

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@azaidi06 azaidi06 marked this pull request as draft October 26, 2024 19:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (b0f9156) to head (058514c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         384      384              
  Lines       62338    62338              
  Branches    10222    10222              
==========================================
- Hits        48034    48031       -3     
- Misses      11875    11879       +4     
+ Partials     2429     2428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@azaidi06
Copy link
Contributor Author

Do we want apple silicon to be the default cpu to be checking in the Sphinx doc build check? Or intel?

This can be found on line 37 in docs/tutorials/getting_started/mac_osx.rst

@azaidi06 azaidi06 marked this pull request as ready for review October 30, 2024 20:54
@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Oct 31, 2024
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things, but other than that this should be ready to merge.

.github/workflows/integration.yml Outdated Show resolved Hide resolved
docs/tutorials/getting_started/windows.rst Outdated Show resolved Hide resolved
corrected hyperlink in miniforge reference for sphinx docs
corrected hyperlink in miniforge reference for sphinx docs
@azaidi06 azaidi06 requested a review from ksbeattie November 21, 2024 22:58
@lbianchi-lbl
Copy link
Contributor

I'm pretty sure the links that @ksbeattie pointed out are working now. I'm merging this in because I need these changes for fixing #1540.

@lbianchi-lbl lbianchi-lbl merged commit 5841433 into IDAES:main Nov 22, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants