Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the IDAES tag of Pyomo to check for issues #1523

Merged
merged 11 commits into from
Nov 19, 2024

Conversation

blnicho
Copy link
Member

@blnicho blnicho commented Nov 7, 2024

Summary/Motivation:

Checking for issues ahead of the Pyomo release

Changes proposed in this PR:

  • Bumping the IDAES tag of Pyomo to test against Pyomo main

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho blnicho added Priority:High High Priority Issue or PR CI:run-integration triggers_workflow: Integration labels Nov 7, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 7, 2024
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Nov 7, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 7, 2024
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Nov 7, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 7, 2024
@blnicho
Copy link
Member Author

blnicho commented Nov 7, 2024

Note: the line restricting flexparser should be removed before merging this but is needed for now to get the idaes get-extensions command working. A new release of pint is expected imminently that should fix this and allow us to revert this change

@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Nov 7, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 7, 2024
@blnicho
Copy link
Member Author

blnicho commented Nov 7, 2024

I'm going to bump the tag again after Pyomo/pyomo#3409 is merged

@lbianchi-lbl
Copy link
Contributor

Converting it to draft while we wait for Pyomo/pyomo#3409 to be merged in, then we should un-draft it when this is ready to be merged (assuming all checks pass).

@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Nov 11, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (7eac461) to head (19247a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         384      384              
  Lines       62335    62335              
  Branches    10222    10222              
==========================================
- Hits        48031    48028       -3     
- Misses      11875    11879       +4     
+ Partials     2429     2428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Nov 14, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 14, 2024
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Nov 15, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 15, 2024
@blnicho blnicho marked this pull request as ready for review November 15, 2024 22:57
@blnicho blnicho marked this pull request as draft November 18, 2024 19:26
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Nov 18, 2024
@blnicho
Copy link
Member Author

blnicho commented Nov 18, 2024

We found a couple small issues with the 6.8.1 release so we're going to cut another patch release today. I'm converting this to a draft again so it doesn't get merged until we're finished cutting Pyomo 6.8.2.

@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 18, 2024
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Nov 19, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 19, 2024
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Nov 19, 2024
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Nov 19, 2024
@blnicho blnicho marked this pull request as ready for review November 19, 2024 15:26
@lbianchi-lbl
Copy link
Contributor

@blnicho I've updated the pyomo requirement to point to the 6.8.2 release. Assuming the checks pass, I'm planning on merging this in. Let me know if there's any reason not to.

@blnicho
Copy link
Member Author

blnicho commented Nov 19, 2024

@lbianchi-lbl this is ready to merge!

@lbianchi-lbl lbianchi-lbl merged commit c4336ba into IDAES:main Nov 19, 2024
64 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants