Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore documentation search in Sphinx/ReadTheDocs #932

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Aug 12, 2022

Resolves #909

Summary/Motivation:

Search doesn't work and we'd like it to work. See #909 (comment) for a before/after

Changes proposed in this PR:

  • Remove JS files from the repo that were shadowing the ones provided by Sphinx/ReadTheDocs

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #932 (f5c6660) into main (518cf5c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f5c6660 differs from pull request most recent head 719dbc8. Consider uploading reports for the commit 719dbc8 to get more accurate results

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   70.07%   70.06%   -0.01%     
==========================================
  Files         573      573              
  Lines       64007    64007              
  Branches    12053    12053              
==========================================
- Hits        44850    44847       -3     
- Misses      16868    16872       +4     
+ Partials     2289     2288       -1     
Impacted Files Coverage Δ
idaes/ver.py 61.53% <0.00%> (-4.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Aug 18, 2022
@ksbeattie ksbeattie marked this pull request as ready for review August 18, 2022 18:16
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp.

@andrewlee94 andrewlee94 enabled auto-merge (squash) August 18, 2022 18:17
@ksbeattie ksbeattie disabled auto-merge August 18, 2022 18:31
@ksbeattie ksbeattie merged commit a82afa1 into IDAES:main Aug 18, 2022
ksbeattie added a commit that referenced this pull request Nov 15, 2022
Co-authored-by: Keith Beattie <[email protected]>
(cherry picked from commit a82afa1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Search broken on ReadTheDocs
3 participants