Alignment of footer adderess #33
Conversation
|
Attach a screenshot/working video of your change. |
|
here is the screen shot |
|
Unable to view the screenshot |
|
@anshkarwasra check size of the icon from the figma file |
There was a problem hiding this comment.
@anshkarwasra you have included the changes of your previous 2 pr's in this pr as well
please remove it
and also as visible from your screen shot that the logos don't match the figma please correct that as well
for any problem fell free to ask at discord
anshkarwasra
force-pushed
the
alignment
branch
from
bdc08cf to
ca6c277
Compare
|
fixed |
There was a problem hiding this comment.
@anshkarwasra these are the changes required,
and here is the figma link
| margin-left: 60px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 10px; |
There was a problem hiding this comment.
you have to maintain overall gap of 36 b/w icons, since you have used 16 as margin, adjust it accordingly?
| } | ||
|
|
||
| .abc { | ||
| display: flex; | ||
| justify-content: center; | ||
| border-radius: 50px; | ||
| font-size: 12px; |
There was a problem hiding this comment.
why? 12 px? see the figma file, size is something else
| margin: 10px; | ||
| padding: 10px; | ||
| margin: 16px; | ||
| height: 50px; |
There was a problem hiding this comment.
both height and width are 48px, see figma
|
Okay and sorry I didn't know how to access figma styles i tried to make by only looking at its design |
|
@anshkarwasra no problem if you didn't had the figma link, it's available in the readme.md in the main directory |
Related Issue
Closes #27
Type of Change
New Feature
Bug Fix
Code Refactor
Documentation Update
Description of Change
re-aligned the footer's contact section
Implementation Details
instead of grid made .row1 container a flex and set
flex-direction: columnand inserted logo and corresponding text in pair-wise 3 divs of classname .footerTxtWrapper and made them inline-flex element and usedalign-items:centerproperty on them