Navbar alignment fixed closes #1 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sanat-Jha check if the distance of logo from the left is same as in figma file |
Yash-g2310
reviewed
Dec 20, 2024
There was a problem hiding this comment.
hey @Sanat-Jha
i guess there is some problem at the mobile view with your commits
please do the required changes
for any question/ clarification/ help, head to discord
@Yash-g2310 should I work on fixing this or not as you have already closed the PR? |
|
@Sanat-Jha Yes, you may work on this. Ill reopen and merge if its correct. |
I have made the fixes and opened a new PR for it #87 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1
Type of Change
Put
xinside the square bracket to specify what type of change your PR is:Description of Change
Fixed the alignment and button looks of navbar
Demo