Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a loader screen. Closes #79 #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Akshat1276
Copy link
Collaborator

@Akshat1276 Akshat1276 commented Dec 30, 2024

Closes #79

Type of Change

  • New Feature
  • Bug Fix
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Change

Added a loader screen with the website logo and welcome message.

Implementation Details

implemented using HTML, CSS, JS.

Demo

Untitled.video.-.Made.with.Clipchamp.10.mp4

@Yash-g2310
Copy link
Collaborator

@Akshat1276 the feature is good, firstly follow the feature template while creating the issue,
also it's not responsive
image

as you can see, so do the changes accordingly

@Akshat1276
Copy link
Collaborator Author

@Yash-g2310 Made the advised changes, and made it responsive too. Kindly check and merge.
Thank You

@Akshat1276 Akshat1276 force-pushed the loaderScreen#79 branch 2 times, most recently from 4f8faa8 to c67a569 Compare January 16, 2025 04:08
@sasmitaditya13
Copy link
Collaborator

@Yash-g2310 review this

@Yash-g2310
Copy link
Collaborator

@Akshat1276 just a small change,
Screenshot 2025-01-17 224742

align the heading and image in mobile view

@Akshat1276
Copy link
Collaborator Author

Akshat1276 commented Jan 18, 2025

@Yash-g2310 Sir in my system, this issue appeared when the width of the viewport was less than 132px, which is extremely small, as almost all phones have their viewport width not less than 200px, so this issue would never be caught. For safety, I have set the min-width for the viewport to 135px. So users won't face this issue. I'm saying this because I was not able to fix it in anyway I know. Please guide me here.
Thank you
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a loader screen when starting the website
3 participants