Rectified Notice State Bug #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rectifies the notice state bug (when a notice is opened via a deeplink , the notice is not shown as read)
Closes #18
Type of change
Bug Patch
Technicalities of change
I added a new field in the noticeIntro obj model to check whether the notice is via a deeplink or not. In the auth repository, if the notice is via a deep link , i added it to the mark read sink and wrote a conditional so that updateUI wouldn't be called for such a case when notice is via a deep link as that was erroroneous
Demo
notice_state_bug.1.1.mp4