feat: Add address and academic registration date in Resident #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beingnoble03
reviewed
Aug 4, 2024
Comment on lines
+23
to
+27
| migrations.AlterField( | ||
| model_name='complaint', | ||
| name='status', | ||
| field=models.CharField(choices=[('res', 'Resolved'), ('pen', 'Pending'), ('unr', 'Unresolved'), ('ipr', 'Inprocess')], default='pen', max_length=10), | ||
| ), |
There was a problem hiding this comment.
This should not be here. Seems wrong.
Hardik-2311
added a commit
that referenced
this pull request
Aug 23, 2024
* feat: Add address and academic registration date in Resident (#51) * feat: Add address and academic registeration date in Resident * Set default value for address_bhawan --------- Co-authored-by: Hardik <[email protected]> * fix: Add new fields to fields in ResidentSerializer (#52) Co-authored-by: Aditya Chopra <[email protected]> * fix: Remove additional fields from ResidentSerializer (#53) Co-authored-by: Aditya Chopra <[email protected]> * fix: Partial update handled * Add migration file --------- Co-authored-by: Hardik <[email protected]> Co-authored-by: Aditya Chopra <[email protected]> Co-authored-by: Aditya Chopra <[email protected]>
Hardik-2311
added a commit
that referenced
this pull request
Aug 23, 2024
* feat: Add address and academic registration date in Resident (#51) * feat: Add address and academic registeration date in Resident * Set default value for address_bhawan --------- Co-authored-by: Hardik <[email protected]> * fix: Add new fields to fields in ResidentSerializer (#52) Co-authored-by: Aditya Chopra <[email protected]> * fix: Remove additional fields from ResidentSerializer (#53) Co-authored-by: Aditya Chopra <[email protected]> * fix: Partial update handled * Add migration file * fix: Handle the invalid date cases for registeration_date --------- Co-authored-by: Hardik <[email protected]> Co-authored-by: Aditya Chopra <[email protected]> Co-authored-by: Aditya Chopra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.