Tinymce #9
Open
Tinymce #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
requested changes
Sep 22, 2020
There was a problem hiding this comment.
Haven't tested it yet.
Few suggestions:
- Never submit a PR via your
master. Although I have told the reason for this in the Git Lecture, feel free to ping me if you didn't understand then. - The commit messages, for our organization, starts with Present Tense. For the changes in the PR, I would probably type something like this:
Change mission, about, description textareas to rich text field. - @pradumangoyal could you please attach the link to the configuration for frontend formatting?
src/components/group-add-post.js
Outdated
|
|
||
| handleEditorChange = (content) => { | ||
| this.setState({text: content.level.content}) | ||
| console.log(content.level.content) |
There was a problem hiding this comment.
Don't leave console.log in the code. This reflects in production environment too.
src/components/group-add-post.js
Outdated
| @@ -20,12 +20,13 @@ import { addPost } from '../actions' | |||
|
|
|||
| import inline from 'formula_one/src/css/inline.css' | |||
| import main from '../css/group-post-card.css' | |||
| import {Editor} from '@tinymce/tinymce-react' | |||
src/components/group-add-post.js
Outdated
|
|
||
| class GroupAddPost extends React.Component { | ||
| constructor (props) { | ||
| super(props) | ||
| this.state = { | ||
| text: '', | ||
| text: "", |
src/components/group-add-post.js
Outdated
| name='text' | ||
| <Editor | ||
| apiKey="fb3pb0ana4mvi60jwhefs3g2u3501d9s915efud2rh6ax2ek" | ||
| /*init={{height=autoHeight}}*/ |
There was a problem hiding this comment.
Don't commit such meaningless comments.
src/components/group-add-post.js
Outdated
| value={this.state.text} | ||
| placeholder='Write something here...' | ||
| initialValue="<p>Write something here...</p>" |
There was a problem hiding this comment.
Why was the p tags necessary?
Can't you simply write it like this - initialValue="Write something here..."?
src/components/group-post-card.js
Outdated
| @@ -106,7 +107,19 @@ class GroupPostCard extends React.Component { | |||
| </div> | |||
| </Card.Content> | |||
| <Card.Content> | |||
| <div styleName='post-card-description'>{post.text}</div> | |||
| <div styleName='post-card-description'><Editor apikey="fb3pb0ana4mvi60jwhefs3g2u3501d9s915efud2rh6ax2ek" init={{ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have replaced plain text fields with HTML Fields