Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure CAP author shows instead of user who created CAP author #143

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Jan 3, 2020

Changes

This pull request makes the following changes:

  • Adds a function to use the wpseo_title filter to use the correct author name for the output page title

Before:
Screen Shot 2020-01-03 at 12 47 16 PM

After:
Screen Shot 2020-01-03 at 12 47 48 PM

Why

For #134

Testing/Questions

Features that this PR affects:

  • Author archive page title

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?

Steps to test this PR:

  1. View a CAP author archive, such as /author/alessia-milstein/ and verify the tab title displays the correct author name

@joshdarby joshdarby requested a review from benlk January 3, 2020 17:49
@joshdarby joshdarby self-assigned this Jan 3, 2020
Copy link
Collaborator

@benlk benlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add this to Largo, later.

@joshdarby
Copy link
Author

I'll make an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants