-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validation): Add helper macros for common validatiors #65
base: feature/validation
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
72e291a
to
13d154f
Compare
14169ec
to
ab13285
Compare
13d154f
to
018f0e1
Compare
ab13285
to
92a83bf
Compare
018f0e1
to
666a1c4
Compare
19c9585
to
2c19248
Compare
666a1c4
to
6f0c976
Compare
2c19248
to
b163eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor requests :)
|
||
cmake_minimum_required(VERSION 3.20) | ||
|
||
# create compile_commands.json for clang | ||
set(CMAKE_EXPORT_COMPILE_COMMANDS on) | ||
|
||
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) | ||
|
||
project(user-settings-sample-validation) | ||
|
||
zephyr_compile_options(-fdiagnostics-color=always) | ||
|
||
zephyr_include_directories(src) | ||
target_sources(app PRIVATE src/main.c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up the cmakelists file:
cmake_minimum_required(VERSION 3.20) | |
# create compile_commands.json for clang | |
set(CMAKE_EXPORT_COMPILE_COMMANDS on) | |
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) | |
project(user-settings-sample-validation) | |
zephyr_compile_options(-fdiagnostics-color=always) | |
zephyr_include_directories(src) | |
target_sources(app PRIVATE src/main.c) | |
cmake_minimum_required(VERSION 3.20) | |
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) | |
project(user-settings-sample-validation) | |
zephyr_include_directories(src) | |
target_sources(app PRIVATE src/main.c) |
Please check if other files need similar cleanup.
# disable the settings shell to not confuse the user with | ||
# 2 similar top level commands | ||
CONFIG_SETTINGS_SHELL=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be n
, based on the comment?
@@ -0,0 +1,6 @@ | |||
# Validation | |||
|
|||
Sample to demonstrate the validation helpers of the user_settings lib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please briefly describe how the sample does this. I see that the shell is enabled, so this file should atleast say that is expected that the user should check the source code to see what is the expected range (or expected exact size) and then try changing that setting over the shell.
Description
Adds helper macros for common validators.
Adds a new sample that demonstrates the use of these helper macros.
(Also updates the readme in a separate commit)
Related #47
Areas of interest for the reviewer
All
Checklist
After-review steps