Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDL v2 Support #1

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

KDL v2 Support #1

wants to merge 16 commits into from

Conversation

IceDragon200
Copy link
Owner

@IceDragon200 IceDragon200 commented Dec 13, 2023 •
edited
Loading

This PR will be tracking the changes needed to support KDL2.

Design Decisions

  • KDL1 will continue to be supported (available in the Kuddle.V1 namespace)
  • The new default for kuddle will be the V2 modules, this will require existing users to either adapt to the new standard, or change their code to call the V1 modules
  • In the event of a KDL3, the groundwork will already be in place for kuddle to support it, and the same decisions as above will apply in that case
  • Because Kuddle abstracts away the document's representation (i.e. same tokens at the end of the day) most of its functionality remains unchanged, the only difference is the encoding/decoding modules

@IceDragon200
Laying the groundwork for KDL2 support
732a946 
By first moving the original V1 modules into their own namespace, since we'll need those around for compatibility, it will still break existing users, but they should be able to continue by just prefixing the appropriate modules
@IceDragon200
Move original v1 test fixtures into their own subdirectory
ba8bb62 
Since v1 test cases no longer work against the v2 spec
@IceDragon200
Strings and v2 tokenizer refactor
713ea51 
So most of the changes currently are centered around strings and handling new keyword forms
@IceDragon200
Moved tab escape sequence above whitespace stripping tokenize
42b9e63
@IceDragon200
Handle invalid unicode scalars from escape
1dcfd20
@IceDragon200 IceDragon200 changed the title KDL2 Support KDL v2 Support Dec 13, 2023
@IceDragon200 IceDragon200 mentioned this pull request Feb 7, 2024
Open
@zkat zkat mentioned this pull request Feb 7, 2024
Open
29 tasks
@IceDragon200
kuddle/v2: Add support for kdl v2 draft-4 keywords: #nan, #inf, #-inf
7c72be3
@IceDragon200
kuddle/v2: Fixed multiline strings failing when there was an empty tr…
09dd83d 
…uncated line

That is a line that only has its newline and no spaces inside a multiline string, these can occur from space trimming by text editors and is expected to work as if it had sufficient spaces to begin with
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IceDragon200