-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.14.5 #10341
Release v2.14.5 #10341
Conversation
### Bug Fixes | ||
|
||
* Don't close anonymous connections before sending the response for a certificate request #10337 | ||
* Performance data: Don't discard min/max values even if crit/warn thresholds aren’t given #10339 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two bugfixes? I'd include at least one more from https://github.com/Icinga/icinga2/pulls?q=is%3Apr+label%3A%22consider+backporting%22+is%3Aclosed+milestone%3A2.15.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I prefer getting a quick regression fix out for #10330 rather than spending too much time going over other PRs that don't seem too important.
I'd include at least one more
Just so that there are three instead of two? At least that doesn't sound like you'd think any one of them is particularly important.
I've additionally included #10339 because that's a fix that I understood quickly and seems to be properly tested by the unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so that there are three instead of two?
Only two bugfixes in a non-security release look a bit too few to me.
At least that doesn't sound like you'd think any one of them is particularly important.
(Please could you formulate guesses about what I meant but didn't write as questions in the future?)
Actually, I wanted you to have the freedom to choose. After all, different people consider different stuff more/less important.
other PRs that don't seem too important.
- The bug fixed by Don't set Notification#no_more_notifications on custom notifications #7818 is indeed annoying, but tolerate-able
- The bug fixed by OpenTsdbWriter#CheckResultHandler(): skip custom tags with empty values #7928 could theoretically be worked around via default template, but I'm not sure
- The bug fixed by Reset all signal handlers of child processes #8011 however breaks check plugins – we're Icinga, we should enable people to use check plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two bugfixes in a non-security release look a bit too few to me.
Primarily, it's a release to fix a regression in 2.14.4, so it would also be totally fine if it just included #10337 and nothing else.
The usual version bump and changelog for the version, nothing special.
refs #10338