Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.14.5 #10341

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Release v2.14.5 #10341

merged 1 commit into from
Feb 5, 2025

Conversation

julianbrost
Copy link
Contributor

@julianbrost julianbrost commented Feb 4, 2025

The usual version bump and changelog for the version, nothing special.

refs #10338

@julianbrost julianbrost added this to the 2.14.5 milestone Feb 4, 2025
@cla-bot cla-bot bot added the cla/signed label Feb 4, 2025
### Bug Fixes

* Don't close anonymous connections before sending the response for a certificate request #10337
* Performance data: Don't discard min/max values even if crit/warn thresholds aren’t given #10339
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I prefer getting a quick regression fix out for #10330 rather than spending too much time going over other PRs that don't seem too important.

I'd include at least one more

Just so that there are three instead of two? At least that doesn't sound like you'd think any one of them is particularly important.

I've additionally included #10339 because that's a fix that I understood quickly and seems to be properly tested by the unit tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so that there are three instead of two?

Only two bugfixes in a non-security release look a bit too few to me.

At least that doesn't sound like you'd think any one of them is particularly important.

(Please could you formulate guesses about what I meant but didn't write as questions in the future?)

Actually, I wanted you to have the freedom to choose. After all, different people consider different stuff more/less important.

other PRs that don't seem too important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two bugfixes in a non-security release look a bit too few to me.

Primarily, it's a release to fix a regression in 2.14.4, so it would also be totally fine if it just included #10337 and nothing else.

@julianbrost julianbrost merged commit 8550829 into support/2.14 Feb 5, 2025
23 checks passed
@julianbrost julianbrost deleted the icinga-2.14.5 branch February 5, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants