Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Notification#command_endpoint #8404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce Notification#command_endpoint #8404

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Oct 29, 2020 •
edited
Loading

... for delegating notification execution to a specific endpoint.

fixes #8140

@Al2Klimov Al2Klimov self-assigned this Oct 29, 2020
@icinga-probot icinga-probot bot added this to the 2.13.0 milestone Oct 29, 2020
@icinga-probot icinga-probot bot added area/notifications Notification events enhancement New feature or request labels Oct 29, 2020
@Al2Klimov Al2Klimov marked this pull request as draft October 29, 2020 10:38
@Al2Klimov
Copy link
Member Author

Al2Klimov commented Oct 29, 2020 •
edited
Loading

Blocked by

@Al2Klimov Al2Klimov force-pushed the feature/notification-command-endpoint-8140 branch from 4451b2e to 697512b Compare October 29, 2020 11:48
@Al2Klimov
Copy link
Member Author 

[2020-10-29 13:28:12 +0100] notice/JsonRpcConnection: Received 'event::ExecuteCommand' message from identity 'master'.
[2020-10-29 13:28:12 +0100] notice/Process: Running command 'echo' '2' 'root@localhost' 'PROBLEM': PID 50566
[2020-10-29 13:28:12 +0100] notice/Process: PID 50566 ('echo' '2' 'root@localhost' 'PROBLEM') terminated with exit code 0

@Al2Klimov Al2Klimov force-pushed the feature/notification-command-endpoint-8140 branch from 697512b to 56bdfcf Compare October 29, 2020 12:31
@Al2Klimov Al2Klimov removed their assignment Oct 29, 2020
@Al2Klimov Al2Klimov changed the title WIP Introduce Notification#command_endpoint Oct 29, 2020
@Al2Klimov Al2Klimov force-pushed the feature/notification-command-endpoint-8140 branch from 56bdfcf to a0463bf Compare December 14, 2020 13:22
@Al2Klimov Al2Klimov marked this pull request as ready for review December 14, 2020 13:22
@Al2Klimov Al2Klimov modified the milestones: 2.13.0, 2.14.0 Jun 2, 2021
@Al2Klimov
Copy link
Member Author

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Aug 4, 2021
@rafi0101
Copy link

Hi, any news on this topic?

@rafi0101
Copy link

rafi0101 commented Apr 5, 2022

Any news on this topic?
Isn't that already programmed?

@hoizfux
Copy link

hoizfux commented Apr 11, 2022

I would also be very happy about that feature :)

@rafi0101
Copy link

@Al2Klimov what else is being waited for in this pull request?

@Al2Klimov
Copy link
Member Author

A review from a colleague.

@bechtle-simon-mueller
Copy link

Come on guys, what's the keep-up? In other open source tools you can choose if you want to notify from satellite or master since years. -_-

@Al2Klimov
Copy link
Member Author

Workaround

Let $NODE1 run a notification command as usual which does SSH to $NODE2 and does the actual stuff there.

@julianbrost julianbrost removed this from the 2.14.0 milestone Feb 13, 2023
@Al2Klimov
Introduce Notification#command_endpoint
88be719 
for delegating notification execution to a specific endpoint.
@Al2Klimov Al2Klimov force-pushed the feature/notification-command-endpoint-8140 branch from a0463bf to 88be719 Compare February 4, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/notifications Notification events cla/signed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to trigger an execution on an agent
5 participants
@Al2Klimov @rafi0101 @hoizfux @bechtle-simon-mueller @julianbrost