ConfigItem::GetItems(): cache result #9582

Al2Klimov · 2022-11-15T14:52:41Z

to avoid malloc(), refcounts and lock waits.

lib/base/scriptutils.cpp

Al2Klimov · 2022-11-15T16:03:50Z

(Almost +1 minute additionally, yay.)

Al2Klimov · 2022-12-06T11:53:14Z

Before/after, `time icinga2 daemon -C`

f59f361
real 36m38.277s
user 196m31.058s
sys 71m49.837s

real 35m14.356s
user 190m16.353s
sys 68m23.075s

real 35m35.668s
user 192m36.516s
sys 68m44.489s

70d432d
real 34m21.486s
user 181m32.399s
sys 70m31.209s

real 35m12.037s
user 186m11.483s
sys 70m50.715s

real 34m35.143s
user 184m41.342s
sys 69m19.343s

to avoid malloc(), refcounts and lock waits.

Al2Klimov self-assigned this Nov 15, 2022

cla-bot bot added the cla/signed label Nov 15, 2022

Al2Klimov commented Nov 15, 2022

View reviewed changes

lib/base/scriptutils.cpp Outdated Show resolved Hide resolved

Al2Klimov force-pushed the ConfigItem-GetItems branch from 3e128d4 to 58865d3 Compare November 16, 2022 11:46

Al2Klimov force-pushed the ConfigItem-GetItems branch from 58865d3 to 70d432d Compare November 30, 2022 10:09

Al2Klimov removed their assignment Jan 31, 2023

ConfigItem::GetItems(): cache result

7346d40

to avoid malloc(), refcounts and lock waits.

Al2Klimov force-pushed the ConfigItem-GetItems branch from 70d432d to 7346d40 Compare February 3, 2025 17:00