DirectorJob: fix restoring from snapshot

fixes #2528
Icinga · Sep 30, 2022 · 4bca121 · 4bca121
1 parent 6fe74ea
commit 4bca121
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/doc/82-Changelog.md b/doc/82-Changelog.md
@@ -16,6 +16,7 @@ v1.10.1 (unreleased)
 
 ### Configuration Baskets
 * FIX: restore Import/Sync/Job when exported with v1.10 (#2620)
+* FIX: restoring Job with ImportSource or SyncRule (#2528)
 
 ### Database Schema
 * FIX: new DB schema failed due to duplicate line in SQL statement (#2609)

diff --git a/library/Director/Objects/DirectorJob.php b/library/Director/Objects/DirectorJob.php
@@ -251,6 +251,21 @@ public static function import($plain, Db $db, $replace = false)
             $object = static::create([], $db);
         }
 
+        $settings = (array) $properties['settings'];
+
+        if (array_key_exists('source', $settings) && ! (array_key_exists('source_id', $settings))) {
+            $val = ImportSource::load($settings['source'], $db)->get('id');
+            $settings['source_id'] = $val;
+            unset($settings['source']);
+        }
+
+        if (array_key_exists('rule', $settings) && ! (array_key_exists('rule_id', $settings))) {
+            $val = SyncRule::load($settings['rule'], $db)->get('id');
+            $settings['rule_id'] = $val;
+            unset($settings['rule']);
+        }
+
+        $properties['settings'] = (object) $settings;
         $object->setProperties($properties);
         if ($id !== null) {
             $object->reallySet($idCol, $id);