Host|ServiceActions: Don't check object access if monitoring isn't ac…

…tive
Icinga · Sep 1, 2021 · 82ae0dc · 82ae0dc
1 parent 435b1f9
commit 82ae0dc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/library/Director/ProvidedHook/Monitoring/HostActions.php b/library/Director/ProvidedHook/Monitoring/HostActions.php
@@ -46,7 +46,7 @@ protected function getThem(Host $host)
         $auth = Auth::getInstance();
         if (Util::hasPermission('director/monitoring/hosts')) {
             $monitoring = new Monitoring();
-            if ($monitoring->authCanEditHost($auth, $hostname)) {
+            if ($monitoring->isAvailable() && $monitoring->authCanEditHost($auth, $hostname)) {
                 $allowEdit = IcingaHost::exists($hostname, $db);
             }
         }

diff --git a/library/Director/ProvidedHook/Monitoring/ServiceActions.php b/library/Director/ProvidedHook/Monitoring/ServiceActions.php
@@ -56,7 +56,10 @@ protected function getThem(Service $service)
             $title = mt('director', 'Modify');
         } elseif (Util::hasPermission('director/monitoring/services')) {
             $monitoring = new Monitoring();
-            if ($monitoring->authCanEditService(Auth::getInstance(), $hostname, $serviceName)) {
+            if (
+                $monitoring->isAvailable()
+                && $monitoring->authCanEditService(Auth::getInstance(), $hostname, $serviceName)
+            ) {
                 $title = mt('director', 'Modify');
             }
         } elseif (Util::hasPermission('director/monitoring/services-ro')) {