Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden datafields should forbid autocompletion #2347

Open
lazyfrosch opened this issue Jun 30, 2021 · 1 comment
Open

Hidden datafields should forbid autocompletion #2347

lazyfrosch opened this issue Jun 30, 2021 · 1 comment

Comments

@lazyfrosch
Copy link
Contributor

lazyfrosch commented Jun 30, 2021

Expected Behavior

Our password fields are not meant to be autocompleted, so we should disable it.

Current Behavior

Chrome tends to auto-fill passwords into datafields when they are hidden/passwords, when a single secret is stored for the Icinga site. Even when other data is pre-filled into the fields.

Firefox will usually ask, but not autofill it.

Possible Solution

Set autocompletion="off" for the hidden inputs, maybe add this as setting for datafields in general?

Your Environment

  • Director version (System - About): 1.8.0
  • Icinga Web 2 version and modules (System - About): 2.8.2
@moreamazingnick
Copy link
Contributor

autocomplete="off" gets ignored by Google Chrome

autocomplete = "new-password" works

the changes can be made in

modules/director/application/views/helpers/FormStoredPassword.php

Pull request comming soon...

Best Regards
Nicolas

moreamazingnick added a commit to RISE-GmbH/icingaweb2-module-director that referenced this issue Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants