Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Content-Security-Policy #2857

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Support Content-Security-Policy #2857

merged 5 commits into from
Jan 25, 2024

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jan 12, 2024 •
edited by nilmerg
Loading

resolves #2845

@sukhwinder33445 sukhwinder33445 self-assigned this Jan 12, 2024
@cla-bot cla-bot bot added the cla/signed label Jan 12, 2024
@sukhwinder33445 sukhwinder33445 marked this pull request as draft January 12, 2024 15:02
@sukhwinder33445 sukhwinder33445 marked this pull request as ready for review January 17, 2024 09:47
raviks789
raviks789 reviewed Jan 17, 2024
View reviewed changes
library/Director/DirectorObject/Automation/BasketDiff.php Outdated Show resolved Hide resolved
public/css/module.less Outdated Show resolved Hide resolved
nilmerg
nilmerg requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still an onclick attribute defined in ImportsourceController:183

@nilmerg
Copy link
Member

nilmerg commented Jan 19, 2024

please rebase

@nilmerg nilmerg added this to the v1.11.1 milestone Jan 25, 2024
@nilmerg nilmerg merged commit 35c6086 into master Jan 25, 2024
15 checks passed
@nilmerg nilmerg deleted the support-strict-csp branch January 25, 2024 09:44
martialblog added a commit to martialblog/icingaweb2 that referenced this pull request Jun 14, 2024
@martialblog
Add Icinga Director to lits of components capable of strict CSP
fc4b5e3 
 - Was implemented in Icinga/icingaweb2-module-director#2857
@martialblog martialblog mentioned this pull request Jun 14, 2024
Merged
nilmerg pushed a commit to Icinga/icingaweb2 that referenced this pull request Aug 8, 2024
@martialblog
Add Icinga Director to list of components capable of strict CSP (#5226)
66fb1ea 
Hi, 

I updated the docs for the Content Security Policy (CSP). The Director
was missing from the list.

Was implemented in
Icinga/icingaweb2-module-director#2857

Edit: I also added a hint about how to enable CSP in Icinga Web.

Cheers
Markus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

@raviks789 raviks789 Awaiting requested review from raviks789

Assignees

@sukhwinder33445 sukhwinder33445

Labels
cla/signed enhancement
Projects
None yet
Milestone
v1.11.1
Development

Successfully merging this pull request may close these issues.

Support strict CSP
3 participants
@sukhwinder33445 @nilmerg @raviks789