Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom variable rendering hooks #4614

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Custom variable rendering hooks #4614

merged 4 commits into from
Mar 2, 2022

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Dec 2, 2021

resolves #3479

@nilmerg nilmerg added enhancement New feature or improvement area/framework Affects third party integration/development area/monitoring Affects the monitoring module labels Dec 2, 2021
@nilmerg nilmerg self-assigned this Dec 2, 2021
@cla-bot cla-bot bot added the cla/signed label Dec 2, 2021
@nilmerg nilmerg mentioned this pull request Dec 2, 2021
Merged
@nilmerg nilmerg force-pushed the feature/custom-variable-rendering-hooks-3479 branch from 78ce9b0 to deb7091 Compare December 2, 2021 14:32
@nilmerg nilmerg mentioned this pull request Dec 2, 2021
Merged
@fl0wx
Copy link

fl0wx commented Feb 7, 2022

@nilmerg is it possible that this PR can solve this issue too? Mikesch-mp/icingaweb2-module-grafana#281 (if implemented correctly in grafana module?).

@nilmerg
Copy link
Member Author

nilmerg commented Feb 7, 2022

@fl0wx No, this is only about what is shown in the monitoring module. The end result of either implementation has no effect on who implements it. (i.e. the grafana module)

@fl0wx
Copy link

fl0wx commented Feb 7, 2022

@nilmerg ok thanks. Any suggestions who else could help with my issue? There is unfortunately no activity on the issue and im out of ideas.

@nilmerg
Copy link
Member Author

nilmerg commented Feb 7, 2022

https://community.icinga.com might be a good start ;)

@fl0wx
Copy link

fl0wx commented Feb 7, 2022

@nilmerg thanks and i already did that: https://community.icinga.com/t/grafana-module-issue-maintaining-of-grafana-module/9138 Hopefully someone will react. Is there anything i can do if no one will react there too? Sorry for spamming this PR.

@nilmerg nilmerg force-pushed the feature/custom-variable-rendering-hooks-3479 branch from deb7091 to a48bd84 Compare March 2, 2022 09:41
@nilmerg nilmerg merged commit e55422d into master Mar 2, 2022
@nilmerg nilmerg deleted the feature/custom-variable-rendering-hooks-3479 branch March 2, 2022 13:06
@nilmerg nilmerg added this to the 2.10.0 milestone Mar 3, 2022
lippserd added a commit to Icinga/icingaweb2-module-director that referenced this pull request Nov 19, 2024
@lippserd
Enrich custom variable lists in monitoring and icingadb details (#2445)
d56ca2c 
resolves #2239

requires Icinga/icingaweb2#4614 or
Icinga/icingadb-web#467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nilmerg nilmerg

Labels
area/framework Affects third party integration/development area/monitoring Affects the monitoring module cla/signed enhancement New feature or improvement
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Display the Director Caption of a Custom Variable
2 participants
@nilmerg @fl0wx