Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react version in package.json #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eddiecooro
Copy link
Contributor

@eddiecooro eddiecooro commented Feb 8, 2021

The previous version notation was accurate before react team has released the react@17 and react-dom@17
Now we know these versions contain almost no breaking change at all!
So I guess it's safe to kick the can down the line till a future react@18 version 😅

We have issues with the current version since we upgraded to new react-scripts with react@17 and we had to work around it by using the resolutions field in package.json
But I think that wouldn't be that easy to solve for guys that are using npm.

The previous version notation was accurate before react team has released the react@17 and react-dom@17
Now we know these versions contain almost no breaking change at all!
So I guess it's safe to kick the can down the line till a future @18 version 😅
@eddiecooro
Copy link
Contributor Author

On the same note, why you have react in both dependencies and peerDependencies fields? Shouldn't one of them get moved to devDependencies?
Also, why we don't have react-dom as a peerDependency too?

@michiomochi
Copy link

I want this changes too!

@tarunmangukiya
Please review it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants