Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort everything #52

Merged
merged 2 commits into from
Jun 26, 2020
Merged

isort everything #52

merged 2 commits into from
Jun 26, 2020

Conversation

jschlyter
Copy link
Collaborator

Use isort on all code (and be strict about it). Next step may be to use black (if I dare to propose that…)

@jschlyter jschlyter requested a review from rohe June 25, 2020 08:46
@rohe
Copy link
Contributor

rohe commented Jun 25, 2020

Unfortunately the sort function in pycharm does not sort the same way isort does. At least that is my experience.
That creates problems for me. I have to research if one can configure isort to do it the same way.

@jschlyter
Copy link
Collaborator Author

jschlyter commented Jun 26, 2020

Seems to be a way to ask pycharm to work with isort instead of against it, PyCQA/isort#258

@rohe
Copy link
Contributor

rohe commented Jun 26, 2020

Yeah, saw that. Have to look at it closely.

@rohe rohe merged commit 08bf8e5 into IdentityPython:develop Jun 26, 2020
@jschlyter jschlyter deleted the isort branch June 26, 2020 08:07
@rohe
Copy link
Contributor

rohe commented Jun 26, 2020

Looks like I can set it up to work for cryptojwt but then it will not work for oidcmsg or any other project I'm working on.
Adding isort as an external tool seems to be a general tool setting not per project which is what I'd like to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants