Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Wolvic to GeckoView 103.0.2 #256

Merged
merged 8 commits into from
Sep 7, 2022
Merged

Migrate Wolvic to GeckoView 103.0.2 #256

merged 8 commits into from
Sep 7, 2022

Conversation

svillar
Copy link
Member

@svillar svillar commented Sep 6, 2022

We're stuck on 9x's series of Gecko for some months now. After moving to 103.0.2 some of our downstream patches are not needed anymore (either because we've merged them or because the same issue was already fixed upstream).

The most important change from the user POV is that audio issues seem to be gone. Audio hiccups or even worst, the total lack of audio, was reported several times in some experiences. With Gecko 103.0.2 that improves dramatically. Experiences like moonrider.xyz run smoothly and without cuts now (we've run testing rounds of >1h without a single issue).

There is just one con. Whenever GPU process is enabled (and Gecko has it now enabled by default) WebXR sessions do not work. In particular the code that retrieves the connected XR devices does not work and thus the WebXR API cannot be used. That's why we had to temporarily switch the GPU process off to get WebXR working.

@svillar svillar requested review from elima and felipeerias September 6, 2022 16:48
@svillar svillar force-pushed the FIREFOX_103_0_2_RELEASE branch from 75bd5f4 to 690dccf Compare September 6, 2022 16:49
We're now using 103.0.2 in our fork of Gecko so use that also for
maven builds. Update beta and nightly as well to the most recent
versions that work.

Apart from that we're replacing nightly by release as the default
version to be used when using the maven precompiled packages.
This reverts commit b3f1438.

This breaks builds as it does no longer picks the local build and always
uses the maven one.
Copy link
Contributor

@elima elima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and no regressions seen after almost 2 weeks of testing.

This is a major improvement, kudos!

@elima elima merged commit a651090 into main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants