Skip to content

Commit

Permalink
fix: remove callbacks properly in remove_callbacks_for_function()
Browse files Browse the repository at this point in the history
Like remove_current_script_callback just before, also remove from the
ordered_callbacks_map to keep the callback map and ordered callback map
in sync.
  • Loading branch information
travisg committed Apr 16, 2024
1 parent ff6f468 commit bba306d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions modules/script_callbacks.py
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,9 @@ def remove_callbacks_for_function(callback_func):
for callback_list in callback_map.values():
for callback_to_remove in [cb for cb in callback_list if cb.callback == callback_func]:
callback_list.remove(callback_to_remove)
for ordered_callback_list in ordered_callbacks_map.values():
for callback_to_remove in [cb for cb in ordered_callback_list if cb.callback == callback_func]:
ordered_callback_list.remove(callback_to_remove)


def on_app_started(callback, *, name=None):
Expand Down

0 comments on commit bba306d

Please sign in to comment.