Rigid coupled solver #120
Rigid coupled solver #120
Conversation
|
|
||
| # Add these anyway - therefore if you add your own skip_attr you don't have to retype all of these | ||
| self.settings_default['skip_attr'].append(['fortran', | ||
| 'airfoils', | ||
| 'airfoil_db', | ||
| 'settings_types', | ||
| 'ct_dynamic_forces_list', | ||
| 'ct_forces_list', | ||
| 'ct_gamma_dot_list', | ||
| 'ct_gamma_list', | ||
| 'ct_gamma_star_list', | ||
| 'ct_normals_list', | ||
| 'ct_u_ext_list', | ||
| 'ct_u_ext_star_list', | ||
| 'ct_zeta_dot_list', | ||
| 'ct_zeta_list', | ||
| 'ct_zeta_star_list', | ||
| 'dynamic_input']) |
There was a problem hiding this comment.
Just to confirm, these are no longer necessary because when ClassesToSave in the save_timestep() method is used these are not included?
I assume that is the case given the usual remove_cpointers but just to make sure
There was a problem hiding this comment.
I remove these lines of code because settings_default['skip_attr'] is already defined in the class attributes. These lines are just redundant.
I created the save_timestep method for clarity.
There was a problem hiding this comment.
The issue is that if you give a list of attributes to skip as a setting, the settings_default are not used and all of those "rubbish" attributes are included.
So, actually, the original SaveData was incorrect, line 117 in the snippet above should be self.**settings**['skip_attr'].append([<all these attributes>]). That way, you can include your own values to settings['skip_attr'] and those ct_ attributes are included regardless.
There was a problem hiding this comment.
You are right. We should use "extend" instead of "append" to avoid nesting lists.
Thanks
There was a problem hiding this comment.
Ahhh indeed it is extend rather than append. Thanks for spotting that!
Codecov Report
@@ Coverage Diff @@
## develop #120 +/- ##
===========================================
- Coverage 63.08% 62.98% -0.11%
===========================================
Files 122 123 +1
Lines 21278 21374 +96
===========================================
+ Hits 13424 13463 +39
- Misses 7854 7911 +57
Continue to review full report at Codecov.
|
This PR mainly includes a new interface for a rigid structural solver for free systems.
It also includes minor fixes to SHARPy 1.2 and the update to UVLM and xbeam libraries to master.