Lift distribution post-processor #121

sduess · 2021-02-18T10:41:10Z

Lift distribution post-processor was failing due to missing adjustments to previous SHARPy changes. The post-processor now reads aerodynamic forces from aero timestep and adjusts the lift force at nodes shared from two different surfaces (e.g. at symmetry plane). Adjusted lift force along with x-,y-, and z-coordinates of leading are exported to txt format for lift distribution evaluations. Code has no impact on any other SHARPy code.

- Lift distribution post-processor caused error since it was not updated to the latest SHARPy changes - Lift force/ force in z-direction is exported along with x,y, and z coordinates of leading edge and surface id - correction of lift for nodes who share different surface ids (e.g. symmetry plane)

ArturoMS13 · 2021-02-18T15:35:44Z

sharpy/postproc/liftdistribution.py

 import sharpy.utils.cout_utils as cout
-from sharpy.utils.settings import str2bool
 from sharpy.utils.solver_interface import solver, BaseSolver
 import sharpy.utils.settings as settings


Suggested change

import sharpy.utils.settings as settings

import sharpy.utils.settings as settings

import sharpy.aero.utils.mapping as mapping

ArturoMS13 · 2021-02-18T15:36:38Z

sharpy/postproc/liftdistribution.py

-
-        norm = 1.0
-
+        tstep = self.data.aero.timestep_info[self.data.ts]


Suggested change

tstep = self.data.aero.timestep_info[self.data.ts]

aero_tstep = self.data.aero.timestep_info[self.data.ts]

struct_tstep = self.data.structure.timestep_info[self.data.ts]

ArturoMS13 · 2021-02-18T15:38:44Z

sharpy/postproc/liftdistribution.py

+        node_counter = 0
+        for i_surf in range(tstep.n_surf):
+            n_dim, n_m, n_n = tstep.zeta[i_surf].shape
+            forces = tstep.forces[i_surf] + tstep.dynamic_forces[i_surf]


Suggested change

forces = tstep.forces[i_surf] + tstep.dynamic_forces[i_surf]

forces = mapping.aero2struct_force_mapping(

aero_tstep.forces,

self.data.aero.struct2aero_mapping,

aero_tstep.zeta,

structural_tstep.pos,

structural_tstep.psi,

self.data.structure.node_master_elem,

self.data.structure.connectivities,

structural_tstep.cag(),

self.data.aero.aero_dict)

forces += mapping.aero2struct_force_mapping(

aero_tstep.dynamic_forces,

self.data.aero.struct2aero_mapping,

aero_tstep.zeta,

structural_tstep.pos,

structural_tstep.psi,

self.data.structure.node_master_elem,

self.data.structure.connectivities,

structural_tstep.cag(),

self.data.aero.aero_dict)

ArturoMS13 · 2021-02-18T15:40:12Z

sharpy/postproc/liftdistribution.py

-        norm = 1.0
-
+        tstep = self.data.aero.timestep_info[self.data.ts]
+        k_total = 0


Suggested change

k_total = 0

ArturoMS13 · 2021-02-18T15:40:47Z

sharpy/postproc/liftdistribution.py

+            k_total += n_n
+
+        # get aero forces
+        lift_distribution = np.zeros((k_total, 5))


Suggested change

lift_distribution = np.zeros((k_total, 5))

lift_distribution = np.zeros((self.data.structure.num_node, 5))

ArturoMS13 · 2021-02-18T15:41:42Z

sharpy/postproc/liftdistribution.py

+        node_counter = 0
+        for i_surf in range(tstep.n_surf):
+            n_dim, n_m, n_n = tstep.zeta[i_surf].shape


Suggested change

node_counter = 0

for i_surf in range(tstep.n_surf):

n_dim, n_m, n_n = tstep.zeta[i_surf].shape

ArturoMS13 · 2021-02-18T15:42:28Z

sharpy/postproc/liftdistribution.py

+        node_counter = 0
+        for i_surf in range(tstep.n_surf):
+            n_dim, n_m, n_n = tstep.zeta[i_surf].shape
+            forces = tstep.forces[i_surf] + tstep.dynamic_forces[i_surf]
            abs_forces = np.zeros((n_m, n_n))


Suggested change

abs_forces = np.zeros((n_m, n_n))

abs_forces = np.zeros((self.data.structure.num_node))

ArturoMS13 · 2021-02-18T16:02:04Z

Hi Stef,
thank you for the very interesting feature.
I have commit some changes to keep the function compatible with any kind of structure that can be created in sharpy.
Can you have a look at it?
Let me know if I forgot something

ngoiz · 2021-02-18T16:28:01Z

Hi all, and nicely done on this first PR, Stef!

One thing I noticed is that the settings for this solver use what was the old convention (self.settings_default etc. as an instance attribute defined in the class' __init__()). To make the story short, back when I did the documentation builder settings defaults/types... need to be in given as class attributes such that they are included in the docs (the tables that appear online are self generated and require this). So if you can move them to class attributes and include the docstring modification line that'd be great (you can check any solver that has docs online to see how it's done).

Then, another thought that comes to mind is whether we'd like to merge this postproc with AeroForcesCalculator. It seems like both are doing the similar things and a lot of code is very similar. I was just updating it the other day to compute moments as well about the A frame (it is in dev_moments) so maybe we can bring all together to make a more comprehensive solver? Thoughts?

+ fix typos

codecov-commenter · 2021-04-21T18:14:05Z

Codecov Report

Merging #121 (c7c3de8) into develop (affec06) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop     #121      +/-   ##
===========================================
- Coverage    62.56%   62.52%   -0.04%     
===========================================
  Files          124      124              
  Lines        22655    22679      +24     
===========================================
+ Hits         14173    14179       +6     
- Misses        8482     8500      +18

Impacted Files	Coverage Δ
sharpy/utils/algebra.py	`68.00% <10.00%> (-1.04%)`	⬇️
sharpy/postproc/liftdistribution.py	`45.83% <37.50%> (-2.45%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update affec06...c7c3de8. Read the comment docs.

sduess · 2021-04-22T06:23:37Z

Hi guys!
I have updated the lift distribution post-processor. I have adapted some of your suggestions and improved the code. The new setting convention is used now and you can export the lift coefficient for which a panel area calculation was needed and implemented.
For now, I would not merge the postprocessor with the AeroforcesCalculator, as they are highly customized to their respective tasks and not easy to merge.

Let me know what you think!

ngoiz · 2021-04-22T15:53:46Z

sharpy/postproc/liftdistribution.py

+        for inode in range(N_nodes):
+            if self.data.aero.aero_dict['aero_node'][inode]:
+                # transform forces from B to A frame
+                lift_distribution[inode,3]=np.dot(rot.T, forces[inode, :3])[2]  # lift force


Hmm I believe this will not always be the lift force. In the case, say the fluid is rotated but the wing is straight (i.e. A and G coincident) you will not be capturing the perpendicular to the free stream.

How @ArturoMS13 implemented this was to find the free stream direction at the section and project the force onto it (this would be the drag), then, the remainder of the force is assumed to be the lift (there would be a side force component particularly near tips but it makes the calculation simpler).

If you have a look at the Polars file you may it is done there if you'd like to implement it

Also, if I'm not mistaken forces is in B frame. To get them to A you'll need the local CRV to find cab and then you can use rot.T to get them onto G.

This is always so confusing......it's been years for me and still have doubts. I put a little function in algebra called get_transformation() that gets you the projection matrix based on the string you give it.

sharpy/utils/algebra.py

ngoiz

Looking good Stef! I left a few comments on getting the lift but I do agree with you in that it is best keeping this one separate from AeroForcesCalculator.

Let me know if you have any questions about the comments

- local lift is calculated by use a coordinate transformation to the section's local stability coordinate system - similiar to polaraeroforces.py

Co-authored-by: Norberto Goizueta <[email protected]>

ArturoMS13

Thank you for the contribution!

sharpy/postproc/liftdistribution.py

Co-authored-by: Arturo Muñoz-Simón <[email protected]>

ngoiz

Many thanks!

sduess added 3 commits February 18, 2021 10:21

remove: unused library imports from lift distribution post-processor

573e1a5

doc: update documentation of liftdistribution post-processor

32a5c02

sduess requested a review from ArturoMS13 February 18, 2021 10:41

ArturoMS13 reviewed Feb 18, 2021

View reviewed changes

commit suggestions

3889b8a

change sum to norm

1294dd1

sduess added 10 commits April 21, 2021 18:10

Merge branch 'develop' into dev_postproc_changes

7e8dec9

refactor: combine mapping of inertial and dynamic forces

48899b8

+ fix typos

refactor: more dynamic generation and remove i_surf from output

d3c41be

fix: get force in z direction and adjust indices

4690ab8

add: lift coefficients are calculated with panel area

2b97f9a

fix: correct beam nodes shared by different lifting surfaces

550732c

fix[liftdistribution]: import algebra module for panel area

b33affc

fix: use proper setting style and usage

bcddf3a

rename: adapt function name for clarity

d319024

doc: add description for panel area function

9779932

doc: update comments

98e0c2c

ngoiz reviewed Apr 22, 2021

View reviewed changes

sharpy/utils/algebra.py Outdated Show resolved Hide resolved

ngoiz suggested changes Apr 22, 2021

View reviewed changes

sduess and others added 7 commits April 27, 2021 18:21

Merge branch 'dev_airfoil_polars' into dev_postproc_changes

20ea902

Merge branch 'dev_airfoil_polars' into dev_postproc_changes

1c0c527

fix [liftdistribution]: local lift from stability axis transformation

c74ae89

- local lift is calculated by use a coordinate transformation to the section's local stability coordinate system - similiar to polaraeroforces.py

remove [liftdistribution]: unneccessary settings

43d53e3

doc [algebra]: format function description

76c92d5

Co-authored-by: Norberto Goizueta <[email protected]>

Merge branch 'dev_airfoil_polars' into dev_postproc_changes

a866471

Refactor aeroutils functions and code formatting

dff66b4

ngoiz added the enhancement label Apr 28, 2021

ngoiz changed the title ~~Dev postproc changes~~ Lift distribution post-processor Apr 28, 2021

sduess added 3 commits May 10, 2021 07:28

add [liftdistribution]: export nondimensional spanwise coordinate y/s

86e898a

doc: update comments and settings

6bb1ed9

Merge remote-tracking branch 'origin/develop' into dev_postproc_changes

c7c3de8

ArturoMS13 approved these changes Jun 9, 2021

View reviewed changes

sharpy/postproc/liftdistribution.py Outdated Show resolved Hide resolved

refactor: reuse parameter

e590cda

Co-authored-by: Arturo Muñoz-Simón <[email protected]>

ngoiz approved these changes Jun 10, 2021

View reviewed changes

sduess merged commit c3b09a0 into develop Jun 10, 2021

ngoiz deleted the dev_postproc_changes branch May 13, 2022 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lift distribution post-processor #121

Lift distribution post-processor #121

sduess commented Feb 18, 2021

ArturoMS13 Feb 18, 2021

ArturoMS13 Feb 18, 2021

ArturoMS13 Feb 18, 2021

ArturoMS13 Feb 18, 2021

ArturoMS13 Feb 18, 2021

ArturoMS13 Feb 18, 2021

ArturoMS13 Feb 18, 2021

ArturoMS13 commented Feb 18, 2021

ngoiz commented Feb 18, 2021

codecov-commenter commented Apr 21, 2021 •

edited

Loading

sduess commented Apr 22, 2021

ngoiz Apr 22, 2021

ngoiz Apr 22, 2021

ngoiz left a comment

ArturoMS13 left a comment

ngoiz left a comment

	import sharpy.utils.settings as settings
	import sharpy.utils.settings as settings
	import sharpy.aero.utils.mapping as mapping


		norm = 1.0

		tstep = self.data.aero.timestep_info[self.data.ts]

	tstep = self.data.aero.timestep_info[self.data.ts]
	aero_tstep = self.data.aero.timestep_info[self.data.ts]
	struct_tstep = self.data.structure.timestep_info[self.data.ts]

-            forces = tstep.forces[i_surf] + tstep.dynamic_forces[i_surf]
+        forces = mapping.aero2struct_force_mapping(
+            aero_tstep.forces,
+            self.data.aero.struct2aero_mapping,
+            aero_tstep.zeta,
+            structural_tstep.pos,
+            structural_tstep.psi,
+            self.data.structure.node_master_elem,
+            self.data.structure.connectivities,
+            structural_tstep.cag(),
+            self.data.aero.aero_dict)
+        forces += mapping.aero2struct_force_mapping(
+            aero_tstep.dynamic_forces,
+            self.data.aero.struct2aero_mapping,
+            aero_tstep.zeta,
+            structural_tstep.pos,
+            structural_tstep.psi,
+            self.data.structure.node_master_elem,
+            self.data.structure.connectivities,
+            structural_tstep.cag(),
+            self.data.aero.aero_dict)

	lift_distribution = np.zeros((k_total, 5))
	lift_distribution = np.zeros((self.data.structure.num_node, 5))

	node_counter = 0
	for i_surf in range(tstep.n_surf):
	n_dim, n_m, n_n = tstep.zeta[i_surf].shape

	abs_forces = np.zeros((n_m, n_n))
	abs_forces = np.zeros((self.data.structure.num_node))

Lift distribution post-processor #121

Lift distribution post-processor #121

Conversation

sduess commented Feb 18, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArturoMS13 commented Feb 18, 2021

ngoiz commented Feb 18, 2021

codecov-commenter commented Apr 21, 2021 • edited Loading

Codecov Report

sduess commented Apr 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngoiz left a comment

Choose a reason for hiding this comment

ArturoMS13 left a comment

Choose a reason for hiding this comment

ngoiz left a comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 21, 2021 •

edited

Loading