Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XBeam version to include compiler optimisation #271

Merged
merged 9 commits into from
Dec 18, 2023

Conversation

ben-l-p
Copy link
Collaborator

@ben-l-p ben-l-p commented Dec 6, 2023

Updated XBeam to change compile flags used in GFortran. The -ftree-parallelize-loops=4 optimisation flag was found to make the beam solver take considerably longer to run than without it. The -ofast flag was added as this should increase performance in some cases with no noticeable impact on results.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee7206f) 67.69% compared to head (5a92f77) 67.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #271    +/-   ##
========================================
  Coverage   67.69%   67.69%            
========================================
  Files         166      166            
  Lines       26709    26847   +138     
========================================
+ Hits        18081    18175    +94     
- Misses       8628     8672    +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kccwing
Copy link
Collaborator

kccwing commented Dec 6, 2023

I've rerun the docker tests after the new commit for continuation line - let's merge after that's all checked out!
Thanks Ben for fixing this - good work on improving the runtimes for everyone!!

@ben-l-p
Copy link
Collaborator Author

ben-l-p commented Dec 6, 2023

Issue with Docker not building has been resolved. Issue was with a mamba clean statement, with the same issue found HERE. Fixing this doesn't seem so straightforward when done in Docker. For now I have removed this statement, as mamba downloads all the packages anyway during installation, cleaning will only save a bit of storage, and not time.

Copy link
Collaborator

@sduess sduess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ben! Thanks a lot for spotting and speeding up the code.

@sduess sduess merged commit 5aa25e3 into main Dec 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants