-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XBeam version to include compiler optimisation #271
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
========================================
Coverage 67.69% 67.69%
========================================
Files 166 166
Lines 26709 26847 +138
========================================
+ Hits 18081 18175 +94
- Misses 8628 8672 +44 ☔ View full report in Codecov by Sentry. |
I've rerun the docker tests after the new commit for continuation line - let's merge after that's all checked out! |
Issue with Docker not building has been resolved. Issue was with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ben! Thanks a lot for spotting and speeding up the code.
Updated XBeam to change compile flags used in GFortran. The
-ftree-parallelize-loops=4
optimisation flag was found to make the beam solver take considerably longer to run than without it. The-ofast
flag was added as this should increase performance in some cases with no noticeable impact on results.