Added pip install (with docs) #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on/fix_linear_goland_flutter.ipynb Changed Github runner from Conda to Mamba
Also fixed an issue with SHARPy not running due to a package import error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 67.69% 67.69%
=======================================
Files 166 166
Lines 26709 26709
=======================================
Hits 18081 18081
Misses 8628 8628 ☔ View full report in Codecov by Sentry. |
|
Hold off on approving - some packages for a install have been forgotten |
No longer using "pip install mayavi" as this had build errors depending on python version (known bug)
|
Changes have been made to the Mayavi install (required for TVTK) as there is a bug which can causes installation to fail with pip. It now git clones the latest version for installation - this has been tested on Python 3.10/3.11 on both Ubuntu and Mac. Also added a second Conda environment for Apple Silicon, as Conda is yet to fully include GCC/GFortran for this. This is purely removing these packages so that it will still "work", you just need to install them yourself instead. Should all be working now - please test! |
Working like a charm on Debian 12, so I've updated the version in the docs.
rafapalacios
approved these changes
Feb 26, 2024
This was referenced Feb 26, 2024
kccwing
added a commit
that referenced
this pull request
Aug 28, 2024
refer to github PR for reason direct dependency is added - tested to not be necessary as of now, and removed since that blocks pypi artifact upload #280 (comment) https://stackoverflow.com/questions/54887301/how-can-i-use-git-repos-as-dependencies-for-my-pypi-package
kccwing
added a commit
that referenced
this pull request
Oct 9, 2024
* Update CHANGELOG.md for version 2.3 * Change version in installation guide * Updated docs to address issue with conda install failing * Lower NumPy and SciPy version for install * Create pypi_test.yaml for automated CDCI with pipit * change name of package * mayavi direct dependency removed refer to github PR for reason direct dependency is added - tested to not be necessary as of now, and removed since that blocks pypi artifact upload #280 (comment) https://stackoverflow.com/questions/54887301/how-can-i-use-git-repos-as-dependencies-for-my-pypi-package * Create pypi_build.yaml * Update and rename pypi_test.yaml to pypi_build_test.yaml * Addressed and incorporated suggestions from review * Deleted as now incorporated into pypi_build * Renamed job to distinguish actions * Name update for readability * Update readme.md for removing pypi_test * Add rewritten aeroforcescalculator.py using flow angle rotation * Fixed FoR issue with aero forces * Removed commented code in AeroForcesCalculator * include also tarball to pypi * update upload/download-artifact to v4 * use older gcc version to improve compatibility * update gcc action to 4.8 * Update pypi_build.yaml * ubuntu bionic runner deprecated * renaming pypi repo to be consistent with documentation https://ic-sharpy.readthedocs.io/ * pypi rename to ic-sharpy * pypi rename to ic-sharpy * pypi rename to ic-sharpy --------- Co-authored-by: Ben Preston <[email protected]> Co-authored-by: Rafa Palacios <[email protected]> Co-authored-by: Ben Preston <[email protected]>
kccwing
added a commit
that referenced
this pull request
Oct 9, 2024
* Lower NumPy and SciPy version for install * Create pypi_test.yaml for automated CDCI with pipit * change name of package * mayavi direct dependency removed refer to github PR for reason direct dependency is added - tested to not be necessary as of now, and removed since that blocks pypi artifact upload #280 (comment) https://stackoverflow.com/questions/54887301/how-can-i-use-git-repos-as-dependencies-for-my-pypi-package * Create pypi_build.yaml * Update and rename pypi_test.yaml to pypi_build_test.yaml * Update readme.md for pypi * Update readme.md * Update installation.md for PyPI * Update installation.md * Update pypi_build_test.yaml * Addressed and incorporated suggestions from review * Deleted as now incorporated into pypi_build * Renamed job to distinguish actions * Name update for readability * Update readme.md for removing pypi_test * include also tarball to pypi * update upload/download-artifact to v4 * use older gcc version to improve compatibility * update gcc action to 4.8 * Update pypi_build.yaml * ubuntu bionic runner deprecated * renaming pypi repo to be consistent with documentation https://ic-sharpy.readthedocs.io/ * pypi rename to ic-sharpy * pypi rename to ic-sharpy * pypi rename to ic-sharpy --------- Co-authored-by: Ben Preston <[email protected]> Co-authored-by: Rafa Palacios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of Alvaro's pull request HERE, with added documentation and changes to the Github workflows. The Docker build still uses Conda/Mamba - ideally I want to remove this dependency.
Also fixed SciPy issues, as it was using a depreciated FFT function