Add QueryPerformanceTest to the plugin skeleton #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #32.
There are three changes in
viatra.QueryPerformanceTest
in comparison with its origin.QueryPerformanceData
had to be implemented, because Xtend was complaining for missing constructor.Two additional changes were made due to the fact that in MagicDraw it is advised to use V4MD to construct the Viatra engine:
def QueryScope getScope()
is replaced bydef AdvancedViatraQueryEngine getEngine()
.queryEngine = AdvancedViatraQueryEngine.createUnmanagedEngine(preparedScope, getEngineOptions())
is replaced byqueryEngine = engine
.QueryPerformanceTestAdapter
is implemented as an adapter that creates the Viatra Engine by getting it from V4MD. Moreover it extendsRelativeQueryPerformanceTest
so that it can run the measurement.Last but not least, QueryPerformanceTest is responsible for loading the project and calling the adapter to start the measurement on the project.
Please let me know if you have any feedback about this contribution.
One technical debt which might be a no-go: in order to make the PR work, you have to re-enable guava in the plugin skeleton. Otherwise you will get a
NoClassDefFoundError
when running therunTest
gradle job.In order to discuss the problem, the PR does not contain any changes in
build.gradle
yet.